Added SVG optimization guideline #1972

2020-07-02T20:26:26Z

jackmchou commented

2020-07-02 20:26:26 +00:00

(Migrated from github.com)

Description

Resolves: #1971

Check List

I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.
I have read and understand the contributing guidelines.
The project is Free Libre and/or Open Source Software

Netlify preview for the mainly edited page: N/A, edits to contributing.md
Code repository of the project (if applicable): N/A

## Description Resolves: #1971  #### Check List  - [x] I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging. - [x] I have read and understand [the contributing guidelines](https://github.com/privacytools/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [x] The project is [Free Libre](https://en.wikipedia.org/wiki/Free_software) and/or [Open Source](https://en.wikipedia.org/wiki/Open-source_software) Software * Netlify preview for the mainly edited page: N/A, edits to contributing.md * Code repository of the project (if applicable): N/A

nitrohorse (Migrated from github.com) reviewed 2020-07-03 01:38:35 +00:00

nitrohorse (Migrated from github.com) left a comment

Thanks!

dngray (Migrated from github.com) requested changes 2020-07-03 04:15:49 +00:00

dngray (Migrated from github.com) left a comment

I'm thinking this might be better mentioned in the wiki.

There's a couple of other rules too:

We only have SVGs that have a canvas size of 128x128px or 384x128.
Some SVGs generated by Illustrator or Sketch are broken, therefore copying the SVG content to a new canvas is sometimes required. (We found this with the Mailcow logo). Looked fine in local builds but was wrong once rendered through netlify preview etc.

I'm thinking this might be better mentioned in the wiki. There's a couple of other rules too: - We only have SVGs that have a canvas size of 128x128px or 384x128. - Some SVGs generated by Illustrator or Sketch are broken, therefore copying the SVG content to a new canvas is sometimes required. (We found this with the Mailcow logo). Looked fine in local builds but was wrong once rendered through netlify preview etc.

jackmchou commented

2020-07-03 15:21:25 +00:00

(Migrated from github.com)

I'm thinking this might be better mentioned in the wiki.

There's a couple of other rules too:

* We only have SVGs that have a canvas size of 128x128px or 384x128.

* Some SVGs generated by Illustrator or Sketch are broken, therefore copying the SVG content to a new canvas is sometimes required. (We found this with the Mailcow logo). Looked fine in local builds but was wrong once rendered through netlify preview etc.

Updated!

> > > I'm thinking this might be better mentioned in the wiki. > > There's a couple of other rules too: > > * We only have SVGs that have a canvas size of 128x128px or 384x128. > > * Some SVGs generated by Illustrator or Sketch are broken, therefore copying the SVG content to a new canvas is sometimes required. (We found this with the Mailcow logo). Looked fine in local builds but was wrong once rendered through netlify preview etc. Updated!

👍 1

nitrohorse (Migrated from github.com) approved these changes 2020-07-03 18:10:55 +00:00

dngray (Migrated from github.com) approved these changes 2020-07-04 03:11:40 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

nitrohorse

dngray