privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Add 7zip, remove Peazip, Keka not FOSS #1797

Merged
dngray merged 3 commits from pr-pea7zip into master 2020-03-27 04:07:17 +00:00
Conversation 13 Commits 3 Files Changed 3
+15 -14
dngray commented 2020-03-26 09:28:32 +00:00 (Migrated from github.com)
Copy Link
Copy Source

https://deploy-preview-1797--privacytools-io.netlify.com/software/encryption-tools/

Closes: https://github.com/privacytoolsIO/privacytools.io/issues/1782
Closes: https://github.com/privacytoolsIO/privacytools.io/issues/1784

https://deploy-preview-1797--privacytools-io.netlify.com/software/encryption-tools/ Closes: https://github.com/privacytoolsIO/privacytools.io/issues/1782 Closes: https://github.com/privacytoolsIO/privacytools.io/issues/1784
blacklight447 (Migrated from github.com) reviewed 2020-03-26 09:28:32 +00:00
dngray commented 2020-03-26 09:31:19 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Seems that netlify isn't deploying a preview

Seems that netlify isn't deploying a preview
blacklight447 commented 2020-03-26 10:19:09 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Seems that netlify isn't deploying a preview

netlify says this:
Liquid Exception: Invalid syntax for include tag: title="7 Zip" image="/assets/img/svg/3rd-party/7zip.svg" description="<strong>7-Zip</strong> is a free and open-source file archiver, a utility used to place groups of files within compressed containers known as "archives". On Linux the command-line tool p7zip is used and integrates into various interfaces such as <a href="https://wiki.gnome.org/Apps/FileRoller">FileRoller</a>, <a href="https://github.com/ib/xarchiver">Xarchiver</a>, <a href="https://kde.org/applications/utilities/ark">Ark</a> and <a href="https://www.keka.io/">Keka</a>. website="https://7-zip.org" forum="" source="https://sourceforge.net/projects/sevenzip/files/" windows="https://7-zip.org/download.html" linux="https://sourceforge.net/projects/p7zip/files" freebsd="https://www.freshports.org/archivers/p7zip" openbsd="https://sourceforge.net/projects/p7zip" netbsd="https://sourceforge.net/projects/p7zip" Valid syntax: {% include file.ext param='value' param2='value' %} in pages/software/encryption.html 10:28:58 AM: jekyll 3.8.5 | Error: Invalid syntax for include tag: 10:28:58 AM: title="7 Zip" 10:28:58 AM: image="/assets/img/svg/3rd-party/7zip.svg"

seems like you messed up the syntax somewhere.

> Seems that netlify isn't deploying a preview netlify says this: `Liquid Exception: Invalid syntax for include tag: title="7 Zip" image="/assets/img/svg/3rd-party/7zip.svg" description="<strong>7-Zip</strong> is a free and open-source file archiver, a utility used to place groups of files within compressed containers known as "archives". On Linux the command-line tool p7zip is used and integrates into various interfaces such as <a href="https://wiki.gnome.org/Apps/FileRoller">FileRoller</a>, <a href="https://github.com/ib/xarchiver">Xarchiver</a>, <a href="https://kde.org/applications/utilities/ark">Ark</a> and <a href="https://www.keka.io/">Keka</a>. website="https://7-zip.org" forum="" source="https://sourceforge.net/projects/sevenzip/files/" windows="https://7-zip.org/download.html" linux="https://sourceforge.net/projects/p7zip/files" freebsd="https://www.freshports.org/archivers/p7zip" openbsd="https://sourceforge.net/projects/p7zip" netbsd="https://sourceforge.net/projects/p7zip" Valid syntax: {% include file.ext param='value' param2='value' %} in pages/software/encryption.html 10:28:58 AM: jekyll 3.8.5 | Error: Invalid syntax for include tag: 10:28:58 AM: title="7 Zip" 10:28:58 AM: image="/assets/img/svg/3rd-party/7zip.svg"` seems like you messed up the syntax somewhere.
dngray commented 2020-03-26 10:52:59 +00:00 (Migrated from github.com)
Copy Link
Copy Source

seems like you messed up the syntax somewhere.

I guess that's what I get for winging it.

> seems like you messed up the syntax somewhere. I guess that's what I get for winging it.
netlify[bot] commented 2020-03-26 11:13:19 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deploy preview for privacytools-io ready!

Built with commit 21e1381ce4

https://deploy-preview-1797--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 21e1381ce4c8e855a43abb61b3064d55ebc3fe1e https://deploy-preview-1797--privacytools-io.netlify.com
blacklight447 (Migrated from github.com) reviewed 2020-03-26 13:27:17 +00:00
blacklight447 (Migrated from github.com) left a comment

lgtm

lgtm
Mikaela (Migrated from github.com) requested changes 2020-03-26 13:48:29 +00:00
_includes/sections/file-encryption.html
Mikaela (Migrated from github.com) commented 2020-03-26 13:42:35 +00:00

https://forum.privacytools.io/t/discussion-7-zip/3024

https://forum.privacytools.io/t/discussion-7-zip/3024
Mikaela (Migrated from github.com) commented 2020-03-26 13:43:48 +00:00 
  description='<strong>7-Zip</strong> is a free and open-source file archiver, a utility used to place groups of files within compressed containers. On Linux, macOS etc. the command-line tool <a href="http://p7zip.sourceforge.net/"><strong>p7zip</strong></a> is used and integrates into various interfaces such as <a href="https://wiki.gnome.org/Apps/FileRoller">FileRoller</a>, <a href="https://github.com/ib/xarchiver">Xarchiver</a>, <a href="https://kde.org/applications/utilities/ark">Ark</a> and <a href="https://www.keka.io/">Keka</a>.'
```suggestion description='<strong>7-Zip</strong> is a free and open-source file archiver, a utility used to place groups of files within compressed containers. On Linux, macOS etc. the command-line tool <a href="http://p7zip.sourceforge.net/"><strong>p7zip</strong></a> is used and integrates into various interfaces such as <a href="https://wiki.gnome.org/Apps/FileRoller">FileRoller</a>, <a href="https://github.com/ib/xarchiver">Xarchiver</a>, <a href="https://kde.org/applications/utilities/ark">Ark</a> and <a href="https://www.keka.io/">Keka</a>.' ```
Mikaela (Migrated from github.com) commented 2020-03-26 13:47:46 +00:00

I am not sure about Keka. Are there really not open source options or could it have warning on not being OSS?

I am not sure about Keka. Are there really not open source options or could it have warning on not being OSS?
_includes/sections/file-encryption.html
Mikaela (Migrated from github.com) commented 2020-03-26 13:48:08 +00:00

Warn on not being open source?

Warn on not being open source?
dngray (Migrated from github.com) reviewed 2020-03-26 13:52:48 +00:00
_includes/sections/file-encryption.html
dngray (Migrated from github.com) commented 2020-03-26 13:52:48 +00:00

Added

Added
dngray (Migrated from github.com) reviewed 2020-03-26 13:53:56 +00:00
_includes/sections/file-encryption.html
dngray (Migrated from github.com) commented 2020-03-26 13:53:56 +00:00

Yeah I think I'll remove Keka from there, unless we can find an open source alternative. p7zip can be used on MacOS (it's what I used to do via Homebrew/Macports), but I don't have a Mac now, so I've not kept up to date if there's a modern open-source frontend to p7zip.

Yeah I think I'll remove Keka from there, unless we can find an open source alternative. p7zip can be used on MacOS (it's what I used to do via Homebrew/Macports), but I don't have a Mac now, so I've not kept up to date if there's a modern open-source frontend to p7zip.
Mikaela (Migrated from github.com) requested changes 2020-03-26 14:06:20 +00:00
Mikaela (Migrated from github.com) left a comment

I think you missed this part of my previous review

I think you missed this part of my previous review
_includes/sections/file-encryption.html
@@ -38,17 +38,17 @@
{%
Mikaela (Migrated from github.com) commented 2020-03-26 14:06:07 +00:00 
  description='<strong>7-Zip</strong> is a free and open-source file archiver, a utility used to place groups of files within compressed containers. On Linux, MacOS etc. the command-line tool <a href="http://p7zip.sourceforge.net/"><strong>p7zip</strong></a> is used and integrates into various interfaces such as <a href="https://wiki.gnome.org/Apps/FileRoller">FileRoller</a>, <a href="https://github.com/ib/xarchiver">Xarchiver</a>, <a href="https://kde.org/applications/utilities/ark">Ark</a>.'
```suggestion description='<strong>7-Zip</strong> is a free and open-source file archiver, a utility used to place groups of files within compressed containers. On Linux, MacOS etc. the command-line tool <a href="http://p7zip.sourceforge.net/"><strong>p7zip</strong></a> is used and integrates into various interfaces such as <a href="https://wiki.gnome.org/Apps/FileRoller">FileRoller</a>, <a href="https://github.com/ib/xarchiver">Xarchiver</a>, <a href="https://kde.org/applications/utilities/ark">Ark</a>.' ```
Mikaela (Migrated from github.com) approved these changes 2020-03-26 15:09:06 +00:00
Mikaela (Migrated from github.com) left a comment

What is the connection between 7zip and encryption by the way?

What is the connection between 7zip and encryption by the way?
dngray commented 2020-03-26 15:14:40 +00:00 (Migrated from github.com)
Copy Link
Copy Source

What is the connection between 7zip and encryption by the way?

It is an easy way to group a bunch of files and encrypt with symmetric encryption like AES256, secured with a passphrase. It can secure metadata such as filenames too.

I assume peazip was added for some reason like this. Personally I've only ever used 7-Zip on windows, and p7zip on Linux, MacOS etc.

> What is the connection between 7zip and encryption by the way? It is an easy way to group a bunch of files and encrypt with symmetric encryption like AES256, secured with a passphrase. It can secure metadata such as filenames too. I assume peazip was added for some reason like this. Personally I've only ever used 7-Zip on windows, and p7zip on Linux, MacOS etc.
👍 1
nitrohorse (Migrated from github.com) approved these changes 2020-03-27 03:43:54 +00:00
nitrohorse (Migrated from github.com) left a comment

LGTM

LGTM
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
blacklight447
dngray
Mikaela
nitrohorse
Labels
Clear labels
:mag:🤖 Search Engines
I2P
The Invisible Internet Project (I2P)
 OS
Operating Systems
 Self-contained networks
Social media
Tor
Anything covering the Tor network
 WIP
active work in progress, do not merge or PR (yet)!
 XMPP
Extensible Messaging and Presence Protocol
 [m]
Matrix protocol
 approved
approved, waiting for a PR
 dependencies
Pull requests that update a dependency file
 duplicate
feedback wanted
high priority
iOS
low priority
stale
A label for stalebot if it gets added
 streaming
Anything related to media streaming.
 todo
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
 ₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
 ✨ enhancement
❌ software removal
🆕 software suggestion
🆘 critical
🇦🇶 translations
Anything covering a translated version of the site
 🌐 Social News Aggregators
🌐 hosting
🌐 website issue
*Technical* issues with the website.
 🏠 housekeeping
Anything primarily related to site cleanup.
 🐛 bug
👁️ browsers
👥 team chat
💢 conflicting
💬 discussion
💻 hardware
📁 file storage
📝 correction
Correction of content on the website
 📧 email
🔎 research required
🔐 password managers
🔒 VPN
Virtual Private Network
 🔒 file encryption
🖊️ digital notebooks
🗄️ DNS
Domain Name System
 🗨️ instant messaging (im)
🚫 Windows
🤖 Android
🦊 Firefox
Firefox & forks, about:config etc.
 🧰 productivity tools
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1797