Solve issues related to WebRTC #1773

jonah · 2020-03-07T23:59:22Z

Zenithium commented

2020-03-07 23:59:22 +00:00

(Migrated from github.com)

Description

Closes: #1483
Closes: #298
Closes: #1522

Netlify preview for the mainly edited page: https://deploy-preview-1773--privacytools-io.netlify.com/browsers/#webrtc

## Description Closes: #1483 Closes: #298 Closes: #1522 * Netlify preview for the mainly edited page: https://deploy-preview-1773--privacytools-io.netlify.com/browsers/#webrtc

jonah reviewed 2020-03-07 23:59:22 +00:00

netlify[bot] commented

2020-03-08 00:00:13 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit 4d8004e969

https://deploy-preview-1773--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 4d8004e9690e8859490307d5c686c18ed8a51f4f https://deploy-preview-1773--privacytools-io.netlify.com

Zenithium commented

2020-03-08 00:14:35 +00:00

(Migrated from github.com)

There seems to be conflicting information for the interface for doing this. @JonahAragon can you check that these steps are correct? Don't know anyone else who's an Apple user lol

jonah reviewed 2020-03-08 00:37:13 +00:00

_includes/sections/browser-webrtc.html

jonah commented

2020-03-08 00:37:12 +00:00

The menu option you've mentioned here (Remove Legacy WebRTC API) does not exist in Safari. There is a menu option "Enable Legacy WebRTC API" in the WebRTC menu:

...but it appears to be disabled by default in Catalina. I've run some tests and I can't see any evidence that WebRTC implemented in Safari leaks your IP address. I would change your text to:

<h3>How to disable WebRTC in Safari?</h3>

<p>Safari is far stricter with WebRTC than other major browsers, and it does not leak your IP address in its default configuration. If you'd like, you can follow these steps just to double-check your browser:</p>

<ol class="long-string-list">
  <li>Choose "Preferences" under the Safari menu in your menu bar.</li>
  <li>Select the Advanced tab and check the "Show Develop menu in menu bar" box.</li>
  <li>Exit Preferences and open the Develop menu in your menu bar.</li>
  <li>In the drop-down menu, open the "WebRTC" submenu and ensure "Enable Legacy WebRTC API" is unchecked. If it's grayed out, even better.</li>
</ol>

~~Also, I'm not sure if this PR actually closes #298?~~ Seems to in your latest commit 👍

The menu option you've mentioned here (Remove Legacy WebRTC API) does not exist in Safari. There is a menu option "_Enable_ Legacy WebRTC API" in the WebRTC menu: <img width="702" alt="image" src="https://user-images.githubusercontent.com/3637842/76154397-588f2a00-60a1-11ea-848e-db7463302421.png"> ...but it appears to be disabled by default in Catalina. I've run some tests and I can't see any evidence that WebRTC implemented in Safari leaks your IP address. I would change your text to: ```suggestion <h3>How to disable WebRTC in Safari?</h3> <p>Safari is far stricter with WebRTC than other major browsers, and it does not leak your IP address in its default configuration. If you'd like, you can follow these steps just to double-check your browser:</p> <ol class="long-string-list"> <li>Choose "Preferences" under the Safari menu in your menu bar.</li> <li>Select the Advanced tab and check the "Show Develop menu in menu bar" box.</li> <li>Exit Preferences and open the Develop menu in your menu bar.</li> <li>In the drop-down menu, open the "WebRTC" submenu and ensure "Enable Legacy WebRTC API" is unchecked. If it's grayed out, even better.</li> </ol> ``` ~~Also, I'm not sure if this PR *actually* closes #298?~~ Seems to in your latest commit 👍

Zenithium (Migrated from github.com) reviewed 2020-03-08 02:06:48 +00:00

_includes/sections/browser-webrtc.html

Zenithium (Migrated from github.com) commented

2020-03-08 02:06:47 +00:00

Thanks for the assist, they don't call you iJonah for nothing :) The problem was that most sources for this WebRTC implementation were from 2018-2019, and posts from 2020 were just reposting the old stuff -_-

jonah reviewed 2020-03-09 13:23:46 +00:00

jonah left a comment

Is it worth mentioning that you don't need to disable WebRTC entirely in Safari to prevent IP leaks (and I am not sure if it is possible to disable WebRTC entirely??) -- Meaning that in the default config your IP is not leaked, but you are still able to make video calls (AFAIK? can double-check later) etc., which is definitely handy.

Is it worth mentioning that you don't need to disable WebRTC entirely in Safari to prevent IP leaks (and I am not sure if it is possible to disable WebRTC entirely??) -- *Meaning* that in the default config your IP is not leaked, but you are still able to make video calls (AFAIK? can double-check later) etc., which is definitely handy.

_includes/sections/browser-webrtc.html

jonah commented

2020-03-09 13:22:24 +00:00

<p>Chrome on iOS and Internet Explorer do not implement WebRTC yet. <a href="#browser"><i class="fas fa-link"></i> But we recommend using Firefox on all devices.</a></p>

Chrome on iOS

[citation needed]? This may be the same as Safari now (in that WebRTC is supported, because I believe it is supported on Safari on iOS) -- Alternatively if Chrome on iOS doesn't implement WebRTC, we should check if Firefox on iOS and Safari on iOS does implement it in the first place, because they would be worth adding to this list if not. I'll double-check later...

```suggestion <p>Chrome on iOS and Internet Explorer do not implement WebRTC yet. <a href="#browser"><i class="fas fa-link"></i> But we recommend using Firefox on all devices.</a></p> ``` > Chrome on iOS [citation needed]? This may be the same as Safari now (in that WebRTC is supported, because I believe it is supported on Safari on iOS) -- Alternatively *if* Chrome on iOS doesn't implement WebRTC, we should check if Firefox on iOS and Safari on iOS does implement it in the first place, because they would be worth adding to this list if not. I'll double-check later...