Fix collapsing navbar dropdown when clicking another element #1552

jonah · 2019-12-01T02:03:46Z

dawidpotocki commented

2019-12-01 02:03:46 +00:00

(Migrated from github.com)

JavaScript was checking if element clicked is exactly .nav-summary,
which isn't a problem when just clicking text inside it, but if we try
to click another element inside like <span>, it won't work, since now
this span is clicked, not .nav-summary.

Closes #1549

JavaScript was checking if element clicked is exactly `.nav-summary`, which isn't a problem when just clicking text inside it, but if we try to click another element inside like `<span>`, it won't work, since now this span is clicked, not `.nav-summary`. Closes #1549

netlify[bot] commented

2019-12-01 02:04:26 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit e80abf622b

https://deploy-preview-1552--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit e80abf622b4f9dc3c43fb807024969d5fcc8c3e4 https://deploy-preview-1552--privacytools-io.netlify.com

jonah approved these changes 2019-12-01 04:31:54 +00:00

jonah left a comment

Fantastic

nitrohorse (Migrated from github.com) approved these changes 2019-12-01 08:08:09 +00:00

nitrohorse (Migrated from github.com) left a comment

Nice 👍

Nice :+1:

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1552