i18n: Encode length and punctuation in key IDs #1524

2019-11-26T02:01:05Z

djoate commented

2019-11-26 02:01:05 +00:00

(Migrated from github.com)

This is to make don't end up using the same string for two
strings using the same words but different length and punctuation.

For example, there are two strings of different length on the site that started with this exact substring:

You are being watched. Private and state-sponsored organizations are monitoring and recording your online activities.

As a result, the shorter string on the site ended up being superseded by the longer string. I had to bump the max base key length up from 100 to 150. Encoding the length in the key makes sure we don't run into this issue in the future for even longer strings.

This is to make don't end up using the same string for two strings using the same words but different length and punctuation. For example, there are two strings of different length on the site that started with this exact substring: > You are being watched. Private and state-sponsored organizations are monitoring and recording your online activities. As a result, the shorter string on the site ended up being superseded by the longer string. I had to bump the max base key length up from 100 to 150. Encoding the length in the key makes sure we don't run into this issue in the future for even longer strings.

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1524