privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

🌐 Website Issue | Use <picture> instead of changing src of <img> #1468

New Issue
Open
opened 2019-11-06 00:35:34 +00:00 by dawidpotocki · 1 comment
dawidpotocki commented 2019-11-06 00:35:34 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I made that when we set theme, we change src of recommendation <img>, which
might seem okay, but Firefox after doing nothing for few minutes, when later
changing theme, it would change image after some time. Chromium from what I
understand, if we also leave it for some time, when changing theme it would
actually take some time to apply theme, which I feel is because of these
<img>s, I could be wrong here though. Another thing is that it only works
with JavaScript enabled, which I would like to avoid.

So there is <picture> tag which we could use to specify few sources so we
could easily change image depending on @media, which would allow us to make
it work without JavaScript and probably fix these bugs.

<picture> on MDN:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/picture

I made that when we set theme, we change `src` of recommendation `<img>`, which might seem okay, but Firefox after doing nothing for few minutes, when later changing theme, it would change image after some time. Chromium from what I understand, if we also leave it for some time, when changing theme it would actually take some time to apply theme, which I feel is because of these `<img>`s, I could be wrong here though. Another thing is that it only works with JavaScript enabled, which I would like to avoid. So there is `<picture>` tag which we could use to specify few sources so we could easily change image depending on `@media`, which would allow us to make it work without JavaScript and probably fix these bugs. `<picture>` on MDN: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/picture
👍 2
nitrohorse commented 2019-11-06 16:10:28 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Good idea!

Good idea!
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
:mag:🤖 Search Engines
approved
approved, waiting for a PR
 dependencies
Pull requests that update a dependency file
 duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
 iOS
low priority
OS
Operating Systems
 Self-contained networks
Social media
stale
A label for stalebot if it gets added
 streaming
Anything related to media streaming.
 todo
Tor
Anything covering the Tor network
 WIP
active work in progress, do not merge or PR (yet)!
 wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
 XMPP
Extensible Messaging and Presence Protocol
 [m]
Matrix protocol
 ₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
 ✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
 🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
 💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
 🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
 🌐 website issue
*Technical* issues with the website.
 🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
 🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No labels todo 🌐 website issue
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1468