Bump rubyzip from 1.2.3 to 2.0.0 #1456

Merged

dependabot[bot] merged 1 commits from dependabot/bundler/rubyzip-2.0.0 into master 2019-12-01 17:06:07 +00:00

Conversation 7 Commits 1 Files Changed 1 +684 -942

dependabot[bot] commented 2019-11-02 20:39:44 +00:00 (Migrated from github.com)

Copy Link

Bumps rubyzip from 1.2.3 to 2.0.0.

Release notes

Sourced from rubyzip's releases.

v2.0.0

Security

• Default the validate_entry_sizes option to true, so that callers can trust an entry's reported size when using extract #403
  • This option defaulted to false in 1.3.0 for backward compatibility, but it now defaults to true. If you are using an older version of ruby and can't yet upgrade to 2.x, you can still use 1.3.0 and set the option to true.

Tooling / Documentation

• Remove test files from the gem to avoid problems with antivirus detections on the test files #405 / #384
• Drop support for unsupported ruby versions #406

v1.3.0

Security

• Add validate_entry_sizes option so that callers can trust an entry's reported size when using extract #403
  • This option defaults to false for backward compatibility in this release, but you are strongly encouraged to set it to true. It will default to true in rubyzip 2.0.

New Feature

• Add add_stored method to simplify adding entries without compression #366

Tooling / Documentation

• Add more gem metadata links #402

v1.2.4

• Do not rewrite zip files opened with open_buffer that have not changed #360

Tooling / Documentation

• Update example_recursive.rb in README #397
• Hold CI at trusty for now, automatically pick the latest ruby patch version, use rbx-4 and hold jruby at 9.1 #399

Changelog

Sourced from rubyzip's changelog.

2.0.0 (2019-09-25)

Security

• Default the validate_entry_sizes option to true, so that callers can trust an entry's reported size when using extract #403
  • This option defaulted to false in 1.3.0 for backward compatibility, but it now defaults to true. If you are using an older version of ruby and can't yet upgrade to 2.x, you can still use 1.3.0 and set the option to true.

Tooling / Documentation

• Remove test files from the gem to avoid problems with antivirus detections on the test files #405 / #384
• Drop support for unsupported ruby versions #406

1.3.0 (2019-09-25)

Security

• Add validate_entry_sizes option so that callers can trust an entry's reported size when using extract #403
  • This option defaults to false for backward compatibility in this release, but you are strongly encouraged to set it to true. It will default to true in rubyzip 2.0.

New Feature

• Add add_stored method to simplify adding entries without compression #366

Tooling / Documentation

• Add more gem metadata links #402

1.2.4 (2019-09-06)

• Do not rewrite zip files opened with open_buffer that have not changed #360

Tooling / Documentation

• Update example_recursive.rb in README #397
• Hold CI at trusty for now, automatically pick the latest ruby patch version, use rbx-4 and hold jruby at 9.1 #399

Commits

• 2825898 Merge pull request #408 from rubyzip/v2-0-0
• cb407b1 Bump version to 2.0.0
• e1d9af6 Merge pull request #406 from rubyzip/bump-supported-ruby
• 3641a96 Merge pull request #405 from rubyzip/remove-test-files
• e79d9ea Merge pull request #407 from rubyzip/v1-3-0
• 7c65e1e Bump version to 1.3.0
• d65fe7b Merge pull request #403 from rubyzip/check-size
• 35446f4 Drop old ruby and JDK versions from CI
• 74d4bec Remove test files from gem
• 97cb6ae Warn when an entry size is invalid
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [rubyzip](https://github.com/rubyzip/rubyzip) from 1.2.3 to 2.0.0. <details> <summary>Release notes</summary> *Sourced from [rubyzip's releases](https://github.com/rubyzip/rubyzip/releases).* > ## v2.0.0 > Security > > - Default the `validate_entry_sizes` option to `true`, so that callers can trust an entry's reported size when using `extract` [#403](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/403) > - This option defaulted to `false` in 1.3.0 for backward compatibility, but it now defaults to `true`. If you are using an older version of ruby and can't yet upgrade to 2.x, you can still use 1.3.0 and set the option to `true`. > > Tooling / Documentation > > - Remove test files from the gem to avoid problems with antivirus detections on the test files [#405](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/405) / [#384](https://github-redirect.dependabot.com/rubyzip/rubyzip/issues/384) > - Drop support for unsupported ruby versions [#406](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/406) > > ## v1.3.0 > Security > > - Add `validate_entry_sizes` option so that callers can trust an entry's reported size when using `extract` [#403](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/403) > - This option defaults to `false` for backward compatibility in this release, but you are strongly encouraged to set it to `true`. It will default to `true` in rubyzip 2.0. > > New Feature > > - Add `add_stored` method to simplify adding entries without compression [#366](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/366) > > Tooling / Documentation > > - Add more gem metadata links [#402](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/402) > > ## v1.2.4 > - Do not rewrite zip files opened with `open_buffer` that have not changed [#360](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/360) > > Tooling / Documentation > > - Update `example_recursive.rb` in README [#397](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/397) > - Hold CI at `trusty` for now, automatically pick the latest ruby patch version, use rbx-4 and hold jruby at 9.1 [#399](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/399) </details> <details> <summary>Changelog</summary> *Sourced from [rubyzip's changelog](https://github.com/rubyzip/rubyzip/blob/master/Changelog.md).* > # 2.0.0 (2019-09-25) > > Security > > - Default the `validate_entry_sizes` option to `true`, so that callers can trust an entry's reported size when using `extract` [#403](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/403) > - This option defaulted to `false` in 1.3.0 for backward compatibility, but it now defaults to `true`. If you are using an older version of ruby and can't yet upgrade to 2.x, you can still use 1.3.0 and set the option to `true`. > > Tooling / Documentation > > - Remove test files from the gem to avoid problems with antivirus detections on the test files [#405](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/405) / [#384](https://github-redirect.dependabot.com/rubyzip/rubyzip/issues/384) > - Drop support for unsupported ruby versions [#406](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/406) > > # 1.3.0 (2019-09-25) > > Security > > - Add `validate_entry_sizes` option so that callers can trust an entry's reported size when using `extract` [#403](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/403) > - This option defaults to `false` for backward compatibility in this release, but you are strongly encouraged to set it to `true`. It will default to `true` in rubyzip 2.0. > > New Feature > > - Add `add_stored` method to simplify adding entries without compression [#366](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/366) > > Tooling / Documentation > > - Add more gem metadata links [#402](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/402) > > # 1.2.4 (2019-09-06) > > - Do not rewrite zip files opened with `open_buffer` that have not changed [#360](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/360) > > Tooling / Documentation > > - Update `example_recursive.rb` in README [#397](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/397) > - Hold CI at `trusty` for now, automatically pick the latest ruby patch version, use rbx-4 and hold jruby at 9.1 [#399](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/399) </details> <details> <summary>Commits</summary> - [`2825898`](https://github.com/rubyzip/rubyzip/commit/2825898f69fbf1efe4e43452adae6ac5d074ec1c) Merge pull request [#408](https://github-redirect.dependabot.com/rubyzip/rubyzip/issues/408) from rubyzip/v2-0-0 - [`cb407b1`](https://github.com/rubyzip/rubyzip/commit/cb407b106541c345329a017d6eb34026cb372872) Bump version to 2.0.0 - [`e1d9af6`](https://github.com/rubyzip/rubyzip/commit/e1d9af6e46f7eb0d0b728958a57f7e28d60301a4) Merge pull request [#406](https://github-redirect.dependabot.com/rubyzip/rubyzip/issues/406) from rubyzip/bump-supported-ruby - [`3641a96`](https://github.com/rubyzip/rubyzip/commit/3641a963ea0c34275562250d7e67380c85fc2570) Merge pull request [#405](https://github-redirect.dependabot.com/rubyzip/rubyzip/issues/405) from rubyzip/remove-test-files - [`e79d9ea`](https://github.com/rubyzip/rubyzip/commit/e79d9ea2922be12db121c20f5dc55bba8a35418a) Merge pull request [#407](https://github-redirect.dependabot.com/rubyzip/rubyzip/issues/407) from rubyzip/v1-3-0 - [`7c65e1e`](https://github.com/rubyzip/rubyzip/commit/7c65e1e3595031392f1050b81fb2b95b0f2ee764) Bump version to 1.3.0 - [`d65fe7b`](https://github.com/rubyzip/rubyzip/commit/d65fe7bd283ec94f9d6dc7605f61a6b0dd00f55e) Merge pull request [#403](https://github-redirect.dependabot.com/rubyzip/rubyzip/issues/403) from rubyzip/check-size - [`35446f4`](https://github.com/rubyzip/rubyzip/commit/35446f467b739d05790356ab86915de76f0120f1) Drop old ruby and JDK versions from CI - [`74d4bec`](https://github.com/rubyzip/rubyzip/commit/74d4bec371158c4c2a9fe965302dc9649c941a73) Remove test files from gem - [`97cb6ae`](https://github.com/rubyzip/rubyzip/commit/97cb6aefe6d12bd2429d7a2e119ccb26f259d71d) Warn when an entry size is invalid - Additional commits viewable in [compare view](https://github.com/rubyzip/rubyzip/compare/v1.2.3...v2.0.0) </details> <br /> [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/privacytoolsIO/privacytools.io/network/alerts). </details>

🚀 1

netlify[bot] commented 2019-11-02 20:40:26 +00:00 (Migrated from github.com)

Copy Link

Deploy preview for privacytools-io ready!

Built with commit fbc48cc0f7

https://deploy-preview-1456--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit fbc48cc0f7d1e8fae69a3176e41dca5cc259328e https://deploy-preview-1456--privacytools-io.netlify.com

nitrohorse (Migrated from github.com) approved these changes 2019-11-02 21:01:43 +00:00

nitrohorse commented 2019-11-11 00:10:13 +00:00 (Migrated from github.com)

Copy Link

Hmm based on rubyzip's requirements and looking at our Gem lockfile, it appears because we use Ruby v2.0.1 and rubyzip v2 depends on Ruby v2.4 or greater we'll want to ignore this for now.

Hmm based on [rubyzip's requirements](https://github.com/rubyzip/rubyzip#requirements) and looking at [our Gem lockfile](https://github.com/privacytoolsIO/privacytools.io/blob/master/Gemfile.lock#L248), it appears because we use Ruby v2.0.1 and rubyzip v2 depends on Ruby v2.4 or greater we'll want to ignore this for now.

djoate commented 2019-11-23 22:33:55 +00:00 (Migrated from github.com)

Copy Link

Hmm based on rubyzip's requirements and looking at our Gem lockfile, it appears because we use Ruby v2.0.1 and rubyzip v2 depends on Ruby v2.4 or greater we'll want to ignore this for now.

@nitrohorse I don't think the Ruby version in the Gemfile.lock is relevant. The Travis CI builds that run on this Git repo uses Ruby 2.4.1: https://github.com/privacytoolsIO/privacytools.io/pull/1508/checks?check_run_id=316892986, though I could be mistaken (I'm not a Ruby programmer).

> Hmm based on [rubyzip's requirements](https://github.com/rubyzip/rubyzip#requirements) and looking at [our Gem lockfile](https://github.com/privacytoolsIO/privacytools.io/blob/master/Gemfile.lock#L248), it appears because we use Ruby v2.0.1 and rubyzip v2 depends on Ruby v2.4 or greater we'll want to ignore this for now. @nitrohorse I don't think the Ruby version in the Gemfile.lock is relevant. The Travis CI builds that run on this Git repo uses Ruby 2.4.1: https://github.com/privacytoolsIO/privacytools.io/pull/1508/checks?check_run_id=316892986, though I could be mistaken (I'm not a Ruby programmer).

👍 1

nitrohorse commented 2019-11-23 23:21:31 +00:00 (Migrated from github.com)

Copy Link

Hmm based on rubyzip's requirements and looking at our Gem lockfile , it appears because we use Ruby v2.0.1 and rubyzip v2 depends on Ruby v2.4 or greater we'll want to ignore this for now.

@nitrohorse I don't think the Ruby version in the Gemfile.lock is relevant. The Travis CI builds that run on this Git repo uses Ruby 2.4.1: privacytoolsIO/privacytools.io/pull/1508/checks?check_run_id=316892986, though I could be mistaken (I'm not a Ruby programmer).

Ah! Thanks for clarifying; you're right 🤔 Travis does use 2.4.1.

1.14s$ git clone --depth=50 --branch=dependabot/bundler/rubyzip-2.0.0 https://github.com/privacytoolsIO/privacytools.io.git privacytoolsIO/privacytools.io

0.01s
rvm

22.26s$ rvm use 2.4.1 --install --binary --fuzzy

curl: (22) The requested URL returned error: 404 Not Found

Required ruby-2.4.1 is not installed - installing.

curl: (22) The requested URL returned error: 404 Not Found

Searching for binary rubies, this might take some time.

Found remote file https://rvm_io.global.ssl.fastly.net/binaries/ubuntu/16.04/x86_64/ruby-2.4.1.tar.bz2

Checking requirements for ubuntu.

Requirements installation successful.

ruby-2.4.1 - #configure

ruby-2.4.1 - #download

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current

                                 Dload  Upload   Total   Spent    Left  Speed

100 16.4M  100 16.4M    0     0  52.9M      0 --:--:-- --:--:-- --:--:-- 53.0M

ruby-2.4.1 - #validate archive

ruby-2.4.1 - #extract

ruby-2.4.1 - #validate binary

ruby-2.4.1 - #setup

ruby-2.4.1 - #gemset created /home/travis/.rvm/gems/ruby-2.4.1@global

** Updating RubyGems to the latest compatible version for security reasons. **

** If you need an older version, you can downgrade with 'gem update --system OLD_VERSION'. **

ruby-2.4.1 - #importing gemset /home/travis/.rvm/gemsets/global.gems............................................

ruby-2.4.1 - #generating global wrappers.......

ruby-2.4.1 - #uninstalling gem rubygems-bundler-1.4.4.

I'm no Ruby programmer but in this case then I don't think this upgrade should be a problem. Looks like Travis pulls the version from the yaml file which is 2.4.1 😃

> > Hmm based on [rubyzip's requirements](https://github.com/rubyzip/rubyzip#requirements) and looking at [our Gem lockfile](https://github.com/privacytoolsIO/privacytools.io/blob/master/Gemfile.lock#L248) [](/privacytoolsIO/privacytools.io/blob/HEAD@{2019-11-23T22:33:55Z}/Gemfile.lock#L248), it appears because we use Ruby v2.0.1 and rubyzip v2 depends on Ruby v2.4 or greater we'll want to ignore this for now. > > @nitrohorse I don't think the Ruby version in the Gemfile.lock is relevant. The Travis CI builds that run on this Git repo uses Ruby 2.4.1: [privacytoolsIO/privacytools.io/pull/1508/checks?check_run_id=316892986](https://github.com/privacytoolsIO/privacytools.io/pull/1508/checks?check_run_id=316892986), though I could be mistaken (I'm not a Ruby programmer). Ah! Thanks for clarifying; you're right :thinking: Travis [does use 2.4.1](https://travis-ci.com/privacytoolsIO/privacytools.io/builds/134726316). ``` 1.14s$ git clone --depth=50 --branch=dependabot/bundler/rubyzip-2.0.0 https://github.com/privacytoolsIO/privacytools.io.git privacytoolsIO/privacytools.io 0.01s rvm 22.26s$ rvm use 2.4.1 --install --binary --fuzzy curl: (22) The requested URL returned error: 404 Not Found Required ruby-2.4.1 is not installed - installing. curl: (22) The requested URL returned error: 404 Not Found Searching for binary rubies, this might take some time. Found remote file https://rvm_io.global.ssl.fastly.net/binaries/ubuntu/16.04/x86_64/ruby-2.4.1.tar.bz2 Checking requirements for ubuntu. Requirements installation successful. ruby-2.4.1 - #configure ruby-2.4.1 - #download % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 16.4M 100 16.4M 0 0 52.9M 0 --:--:-- --:--:-- --:--:-- 53.0M ruby-2.4.1 - #validate archive ruby-2.4.1 - #extract ruby-2.4.1 - #validate binary ruby-2.4.1 - #setup ruby-2.4.1 - #gemset created /home/travis/.rvm/gems/ruby-2.4.1@global ** Updating RubyGems to the latest compatible version for security reasons. ** ** If you need an older version, you can downgrade with 'gem update --system OLD_VERSION'. ** ruby-2.4.1 - #importing gemset /home/travis/.rvm/gemsets/global.gems............................................ ruby-2.4.1 - #generating global wrappers....... ruby-2.4.1 - #uninstalling gem rubygems-bundler-1.4.4. ``` I'm no Ruby programmer but in this case then I don't think this upgrade should be a problem. Looks like Travis pulls the version from the [yaml file](https://github.com/privacytoolsIO/privacytools.io/blob/master/.travis.yml#L3) which _is_ 2.4.1 :smiley:

nitrohorse (Migrated from github.com) approved these changes 2019-11-23 23:22:02 +00:00

dawidpotocki (Migrated from github.com) approved these changes 2019-12-01 15:09:47 +00:00

This repo is archived. You cannot comment on pull requests.

Reviewers

No Reviewers

nitrohorse

dawidpotocki

Labels

Clear labels

:mag:🤖 Search Engines

approved

approved, waiting for a PR

dependencies

Pull requests that update a dependency file

duplicate

feedback wanted

high priority

I2P

The Invisible Internet Project (I2P)

iOS

low priority

OS

Operating Systems

Self-contained networks

Social media

stale

A label for stalebot if it gets added

streaming

Anything related to media streaming.

todo

Tor

Anything covering the Tor network

WIP

active work in progress, do not merge or PR (yet)!

wontfix

Issues or bugs that will not be fixed and/or do not have significant impact on the project.

XMPP

Extensible Messaging and Presence Protocol

[m]

Matrix protocol

₿ cryptocurrency

ℹ️ help wanted

↔️ file sharing

⚙️ web extensions

Browser Extension related issues

✨ enhancement

❌ software removal

💬 discussion

🤖 Android

🐛 bug

💢 conflicting

📝 correction

Correction of content on the website

🆘 critical

📧 email

🔒 file encryption

📁 file storage

🦊 Firefox

Firefox & forks, about:config etc.

💻 hardware

🌐 hosting

🏠 housekeeping

Anything primarily related to site cleanup.

🔐 password managers

🧰 productivity tools

🔎 research required

🌐 Social News Aggregators

🆕 software suggestion

👥 team chat

🔒 VPN

Virtual Private Network

🌐 website issue

*Technical* issues with the website.

🚫 Windows

👁️ browsers

🖊️ digital notebooks

🗄️ DNS

Domain Name System

🗨️ instant messaging (im)

🇦🇶 translations

Anything covering a translated version of the site

No Label dependencies

Milestone

No items

No Milestone

Assignees

Clear assignees

jonah

No Assignees

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1456