/

privacytools.io

Archived

Reduce flickering with dark/light theme #1241

Merged

dawidpotocki merged 1 commits from reduceflicker into master

2019-08-31 22:30:55 +00:00

dawidpotocki commented

2019-08-30 10:10:09 +00:00

(Migrated from github.com)

It should at least fix going dark -> light -> dark when prefers-color-scheme was set to dark and user changed to light theme and then back to dark using a switch.

It can probably fix other flickering as JavaScript used for loading theme set by using a switch is now loaded at the top of <body>, I guess.

It should at least fix going `dark -> light -> dark` when `prefers-color-scheme` was set to `dark` and user changed to light theme and then back to dark using a switch. It can probably fix other flickering as JavaScript used for loading theme set by using a switch is now loaded at the top of `<body>`, I guess.

netlify[bot] commented

2019-08-30 10:10:48 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit ec8877a28d

https://deploy-preview-1241--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit ec8877a28dca9b0af6c9ff2c37349bc807d434a9 https://deploy-preview-1241--privacytools-io.netlify.com

blacklight447 (Migrated from github.com) reviewed 2019-08-30 10:13:09 +00:00

Mikaela (Migrated from github.com) reviewed 2019-08-30 12:09:50 +00:00

Mikaela (Migrated from github.com) left a comment

I still don't understand the code though, but the description sounds good

I still don't understand the code though, but the description sounds good

Mikaela (Migrated from github.com) approved these changes 2019-08-31 08:54:04 +00:00

nitrohorse (Migrated from github.com) approved these changes 2019-08-31 15:56:09 +00:00

blacklight447 (Migrated from github.com) approved these changes 2019-08-31 16:00:10 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

No Label

🔍🤖 Search Engines

feedback wanted

Self-contained networks

₿ cryptocurrency

ℹ️ help wanted

↔️ file sharing

⚙️ web extensions

✨ enhancement

❌ software removal

💬 discussion

💢 conflicting

📝 correction

🔒 file encryption

📁 file storage

🏠 housekeeping

🔐 password managers

🧰 productivity tools

🔎 research required

🌐 Social News Aggregators

🆕 software suggestion

🌐 website issue

👁️ browsers

🖊️ digital notebooks

🗨️ instant messaging (im)

🇦🇶 translations

No Milestone

No Assignees

1 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1241

No description provided.