Indicate that there is information on DoT hover #1232

2019-08-28T11:43:28Z

dawidpotocki commented

2019-08-28 11:43:28 +00:00

(Migrated from github.com)

Fixes https://github.com/privacytoolsIO/privacytools.io/issues/1199

It's not a question mark, because it seemed to me like we are not sure about that they support DoT or something, huh.

https://deploy-preview-1232--privacytools-io.netlify.com/providers/dns/#icanndns

Fixes https://github.com/privacytoolsIO/privacytools.io/issues/1199 It's not a question mark, because it seemed to me like we are not sure about that they support DoT or something, huh. ![screenshot](https://user-images.githubusercontent.com/38681822/63852920-f2ef1200-c988-11e9-9530-490a9124e6ce.png) * https://deploy-preview-1232--privacytools-io.netlify.com/providers/dns/#icanndns

netlify[bot] commented

2019-08-28 11:44:06 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit 33badc8b48

https://deploy-preview-1232--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 33badc8b48a77a857bc2f53bb8e7a6f1f61e0e80 https://deploy-preview-1232--privacytools-io.netlify.com

blacklight447 (Migrated from github.com) reviewed 2019-08-28 11:50:32 +00:00

Mikaela (Migrated from github.com) reviewed 2019-08-28 12:00:09 +00:00

Mikaela (Migrated from github.com) left a comment

I think it sticks the eye maybe a bit too much, but it's OK

dawidpotocki commented

2019-08-28 12:12:42 +00:00

(Migrated from github.com)

I think it sticks the eye maybe a bit too much, but it's OK

Well if you want I can give DoT normal font-weight and/or use
https://fontawesome.com/icons/info?style=solid.

> I think it sticks the eye maybe a bit too much, but it's OK Well if you want I can give DoT normal font-weight and/or use https://fontawesome.com/icons/info?style=solid.

Mikaela (Migrated from github.com) reviewed 2019-08-28 12:30:52 +00:00

Mikaela (Migrated from github.com) left a comment

That looks a bit better, thanks

blacklight447 (Migrated from github.com) reviewed 2019-08-28 16:01:42 +00:00

blacklight447 (Migrated from github.com) left a comment

ready for merging!

Mikaela commented

2019-08-28 16:10:38 +00:00

(Migrated from github.com)

Looks much better but I think just a space between the DoT and icon would be consistent with the other icons next to text in the table. But otherwise looks good to me.

said @nitrohorse

> Looks much better but I think just a space between the DoT and icon would be consistent with the other icons next to text in the table. But otherwise looks good to me. said @nitrohorse

nitrohorse (Migrated from github.com) reviewed 2019-08-28 16:10:42 +00:00

_includes/sections/dns.html

nitrohorse (Migrated from github.com) commented

2019-08-28 15:14:24 +00:00

Could we add a space between DoT and the span, just for some breathing room?

blacklight447 (Migrated from github.com) reviewed 2019-08-28 18:19:59 +00:00

blacklight447 (Migrated from github.com) left a comment

so is this ready for merging?

Mikaela (Migrated from github.com) reviewed 2019-08-28 18:32:28 +00:00

_includes/sections/dns.html

Mikaela (Migrated from github.com) commented

2019-08-28 18:32:28 +00:00

@blacklight447-ptio Do you think @dawidpotocki should be given time to address this request or that it's currently fine and we can leave it for another PR?

I would wait.

@blacklight447-ptio Do you think @dawidpotocki should be given time to address this request or that it's currently fine and we can leave it for another PR? I would wait.

blacklight447 (Migrated from github.com) reviewed 2019-08-28 18:33:57 +00:00

_includes/sections/dns.html

blacklight447 (Migrated from github.com) commented

2019-08-28 18:33:57 +00:00

if there is more to do, then we wait.

blacklight447 (Migrated from github.com) approved these changes 2019-08-28 19:13:49 +00:00

nitrohorse (Migrated from github.com) approved these changes 2019-08-28 19:16:05 +00:00

nitrohorse (Migrated from github.com) left a comment

Lg!

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1232