web: the desktop version lives in two files, and only one was bumped
src/app.jsx carries its own SB_DESKTOP_VERSION for the compact download table; src/components/ui/DownloadApps.jsx carries DESKTOP_VERSION for the grid. Bumping one leaves the other pointing at a tag whose filenames no longer exist — the failure tests/desktop-download-links.test.mjs was written for, and which it caught here. The i18n scan also learns that these dictionaries feed two clients. The desktop client is a separate repository, so its keys can never appear in a scan of this src/ and were being reported as dead strings to delete.
This commit is contained in:
+1
-1
@@ -1680,7 +1680,7 @@ import { GroupCallMedia, mediaErrorCode } from './group/groupCallMedia.js';
|
||||
// /download/v0.3.0/SecureBit.Chat_0.1.0_x64-setup.exe, a file that never
|
||||
// existed, and the download 404s. A pinned tag keeps serving a real
|
||||
// installer instead.
|
||||
const SB_DESKTOP_VERSION = '0.5.0';
|
||||
const SB_DESKTOP_VERSION = '1.0.0';
|
||||
const SB_DESKTOP_RELEASE = `https://github.com/SecureBitChat/securebit-desktop/releases/download/v${SB_DESKTOP_VERSION}`;
|
||||
const DOWNLOADS = {
|
||||
mac: { name: 'macOS', format: '.dmg · Apple Silicon & Intel', icon: 'fab fa-apple', url: `${SB_DESKTOP_RELEASE}/SecureBit.Chat_${SB_DESKTOP_VERSION}_x64.dmg` },
|
||||
|
||||
Reference in New Issue
Block a user