SecureBitChat/securebit-chat
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix cryptographic random bias in fingerprint mask generation

Browse Source
This commit is contained in:
lockbitchat
2025-10-20 00:42:03 -04:00
parent 60e4bb6b8a
commit 9c1258cd1e
1 changed files with 45 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/network/EnhancedSecureWebRTCManager.js
View File

@@ -4482,17 +4482,17 @@ this._secureLog('info', '🔒 Enhanced Mutex system fully initialized and valida
} }
// Helper function: unbiased integer in [min, max] // Helper function: unbiased integer in [min, max]
getUnbiasedRandomInRange(min, max) { getSafeRandomInt(min, max) {
if (!Number.isInteger(min) || !Number.isInteger(max)) { if (!Number.isInteger(min) || !Number.isInteger(max)) {
throw new Error('getUnbiasedRandomInRange requires integer min and max'); throw new Error('getSafeRandomInt requires integer min and max');
} }
const range = max - min + 1; const range = max - min + 1;
if (range <= 0) throw new Error('Invalid range'); if (range <= 0) throw new Error('Invalid range');
const bytesNeeded = Math.max(1, Math.ceil(Math.log2(range) / 8)); // Для больших диапазонов используем несколько байт
const bytesNeeded = Math.ceil(Math.log2(range) / 8);
const maxValue = Math.pow(256, bytesNeeded); const maxValue = Math.pow(256, bytesNeeded);
const threshold = maxValue - (maxValue % range); const threshold = maxValue - (maxValue % range);
const bucketSize = threshold / range; // exact integer
let randomValue; let randomValue;
do { do {
@@ -4503,15 +4503,14 @@ this._secureLog('info', '🔒 Enhanced Mutex system fully initialized and valida
} }
} while (randomValue >= threshold); } while (randomValue >= threshold);
// Use bucket index instead of modulo return min + (randomValue % range);
return min + Math.floor(randomValue / bucketSize);
} }
// Helper: unbiased float in [minFloat, maxFloat] with optional precision // Safe helper: unbiased float in [minFloat, maxFloat] with scale
getUnbiasedRandomFloat(minFloat, maxFloat, scale = 100) { getSafeRandomFloat(minFloat, maxFloat, scale = 100) {
const minInt = Math.round(minFloat * scale); const minInt = Math.round(minFloat * scale);
const maxInt = Math.round(maxFloat * scale); const maxInt = Math.round(maxFloat * scale);
const intVal = this.getUnbiasedRandomInRange(minInt, maxInt); const intVal = this.getSafeRandomInt(minInt, maxInt);
return intVal / scale; return intVal / scale;
} }
@@ -4520,16 +4519,16 @@ this._secureLog('info', '🔒 Enhanced Mutex system fully initialized and valida
const cryptoRandom = crypto.getRandomValues(new Uint8Array(128)); const cryptoRandom = crypto.getRandomValues(new Uint8Array(128));
const mask = { const mask = {
timingOffset: this.getUnbiasedRandomInRange(0, 1500), timingOffset: this.getSafeRandomInt(0, 1500), // 0–1500ms
sizeVariation: this.getUnbiasedRandomFloat(0.75, 1.25), // float, unbiased sizeVariation: this.getSafeRandomFloat(0.75, 1.25), // unbiased float
noisePattern: Array.from(crypto.getRandomValues(new Uint8Array(64))), noisePattern: Array.from(crypto.getRandomValues(new Uint8Array(64))),
headerVariations: [ headerVariations: [
'X-Client-Version', 'X-Session-ID', 'X-Request-ID', 'X-Timestamp', 'X-Signature', 'X-Client-Version', 'X-Session-ID', 'X-Request-ID', 'X-Timestamp', 'X-Signature',
'X-Secure', 'X-Encrypted', 'X-Protected', 'X-Safe', 'X-Anonymous', 'X-Private' 'X-Secure', 'X-Encrypted', 'X-Protected', 'X-Safe', 'X-Anonymous', 'X-Private'
], ],
noiseIntensity: this.getUnbiasedRandomInRange(50, 150), noiseIntensity: this.getSafeRandomInt(50, 150), // 50–150%
sizeMultiplier: this.getUnbiasedRandomFloat(0.75, 1.25), // float, unbiased sizeMultiplier: this.getSafeRandomFloat(0.75, 1.25), // unbiased float
timingVariation: this.getUnbiasedRandomInRange(100, 1100) timingVariation: this.getSafeRandomInt(100, 1100) // 100–1100ms
}; };
return mask; return mask;
} }